Author rhettinger
Recipients pitrou, python-dev, rhettinger, serhiy.storchaka
Date 2015-05-27.21:26:07
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1432761967.19.0.875605280957.issue23359@psf.upfronthosting.co.za>
In-reply-to
Content
[Reply to pitrou that I didn't seem to be able to make on Rietveld]

This part of the code is the most time sensitive and warrants expansion much more than other proposals (set copying, subset tests, etc).  I long aspired to split the lookup and insertion logic.  The former doesn't need dummy tracking and its split relieves the callers of doing dummy checks.  The latter needed to be more tightly integrated with set_insert_entry.  Both sets of logic have different branch prediction statistics depending on the input data.  Working going forward will be made easier for me by having the lookup and insertion logic separated.

The speed-up is modest but this part of a long series of modest speed-ups collectively adding-up to a nice boost.  The next in line is possibly adding likely/unlikely macros to improve the quality of code generation across different platforms. Overall the code size is just about the same it was in Python 2.7.
History
Date User Action Args
2015-05-27 21:26:07rhettingersetrecipients: + rhettinger, pitrou, python-dev, serhiy.storchaka
2015-05-27 21:26:07rhettingersetmessageid: <1432761967.19.0.875605280957.issue23359@psf.upfronthosting.co.za>
2015-05-27 21:26:07rhettingerlinkissue23359 messages
2015-05-27 21:26:07rhettingercreate