Author Jim.Jewett
Recipients Arfrever, Jim.Jewett, alex, asvetlov, benjamin.peterson, eric.araujo, eric.smith, eric.snow, ezio.melotti, flox, gregory.p.smith, introom, josh.r, mrabarnett, ncoghlan, ned.deily, pitrou, refi64, rhettinger, scoder, serhiy.storchaka, tonn81, westurner, yselivanov
Date 2015-05-24.03:21:34
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1432437694.78.0.999900807186.issue16991@psf.upfronthosting.co.za>
In-reply-to
Content
(Just putting my review summary in the main ticket)

I'm going to echo the previous comment that maybe trying to emulate the existing dict implementation too carefully just adds complexity.

The split-keys implementation shows that there is at least some flexibility to the implementation.  Enough that the keys could map to an array offset, rather than directly to the values?

A simple array of key/value pairs (hashing only to ensure hashability, but ignoring it otherwise) should be faster for the really small dicts you care about, like keyword dicts.  (Admittedly, those timing data are fairly out of date, but I would be surprised if it weren't still true.)
History
Date User Action Args
2015-05-24 03:21:34Jim.Jewettsetrecipients: + Jim.Jewett, rhettinger, gregory.p.smith, ncoghlan, pitrou, scoder, eric.smith, benjamin.peterson, ned.deily, ezio.melotti, eric.araujo, mrabarnett, Arfrever, alex, asvetlov, flox, eric.snow, serhiy.storchaka, yselivanov, westurner, refi64, josh.r, tonn81, introom
2015-05-24 03:21:34Jim.Jewettsetmessageid: <1432437694.78.0.999900807186.issue16991@psf.upfronthosting.co.za>
2015-05-24 03:21:34Jim.Jewettlinkissue16991 messages
2015-05-24 03:21:34Jim.Jewettcreate