➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients Saimadhav.Heblikar, jesstess, serhiy.storchaka, terry.reedy
Date 2015-05-15.05:07:57
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1431666478.25.0.073268613331.issue22133@psf.upfronthosting.co.za>
In-reply-to
Content 
> Just a suggestion, can we use sys.version_info to get Python major version to have uniform code?

Uniform code is too verbose. WM_CLASS should be "Idle" on Python 2 and "Idle3" on Python 3.

    top = Toplevel(self.root, class_='Idle' if sys.version_info[0] <= 2 else 'Idle%s' % sys.version_info[0])

It is easy to write just the constant literal. It is changed only when the major version is changed.
History
Date User Action Args
2015-05-15 05:07:58serhiy.storchakasetrecipients: + serhiy.storchaka, terry.reedy, jesstess, Saimadhav.Heblikar
2015-05-15 05:07:58serhiy.storchakasetmessageid: <1431666478.25.0.073268613331.issue22133@psf.upfronthosting.co.za>
2015-05-15 05:07:58serhiy.storchakalinkissue22133 messages
2015-05-15 05:07:57serhiy.storchakacreate