Author petr.viktorin
Recipients barry, ethan.furman, petr.viktorin, serhiy.storchaka, skrah
Date 2015-05-13.14:48:57
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1431528537.69.0.9854561202.issue23699@psf.upfronthosting.co.za>
In-reply-to
Content
From the discussion on the list:

- It needs to be a macro, not function, to support various types (unsigned long long, float; possibly C++ stuff with overriden operators)

- Another suggestion to change the order of arguments; I still think being the same as richcmp and PyObject_RichCompareBool is best.

I believe all the issues raised here and on the list are handled. Could anyone re-review the patch?
If the usage changes are too much, it's possible to only change Include/object.h and Doc/c-api/typeobj.rst, and leave the rest. Should I trim the patch that way?

Anything else I can do to help this get merged?
History
Date User Action Args
2015-05-13 14:48:57petr.viktorinsetrecipients: + petr.viktorin, barry, skrah, ethan.furman, serhiy.storchaka
2015-05-13 14:48:57petr.viktorinsetmessageid: <1431528537.69.0.9854561202.issue23699@psf.upfronthosting.co.za>
2015-05-13 14:48:57petr.viktorinlinkissue23699 messages
2015-05-13 14:48:57petr.viktorincreate