Message243095
From the discussion on the list:
- It needs to be a macro, not function, to support various types (unsigned long long, float; possibly C++ stuff with overriden operators)
- Another suggestion to change the order of arguments; I still think being the same as richcmp and PyObject_RichCompareBool is best.
I believe all the issues raised here and on the list are handled. Could anyone re-review the patch?
If the usage changes are too much, it's possible to only change Include/object.h and Doc/c-api/typeobj.rst, and leave the rest. Should I trim the patch that way?
Anything else I can do to help this get merged? |
|
Date |
User |
Action |
Args |
2015-05-13 14:48:57 | petr.viktorin | set | recipients:
+ petr.viktorin, barry, skrah, ethan.furman, serhiy.storchaka |
2015-05-13 14:48:57 | petr.viktorin | set | messageid: <1431528537.69.0.9854561202.issue23699@psf.upfronthosting.co.za> |
2015-05-13 14:48:57 | petr.viktorin | link | issue23699 messages |
2015-05-13 14:48:57 | petr.viktorin | create | |
|