This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mark.dickinson
Recipients Matt.Mackall, benjamin.peterson, gregory.p.smith, josh.r, larry, mark.dickinson, marmoute, mpm, python-dev, rhettinger, serhiy.storchaka
Date 2015-05-13.12:42:56
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1431520976.71.0.977156721835.issue23971@psf.upfronthosting.co.za>
In-reply-to
Content
From the patch:

-            if (dictresize(mp, Py_SIZE(seq))) {
+            if (dictresize(mp, Py_SIZE(seq) / 2 * 3)) {

Isn't there a risk of signed overflow here?  The dictresize function has an `assert(minused >= 0)`, which is going to fail for values of `Py_SIZE(seq)` that are close to `PY_SSIZE_T_MAX` in the common case where signed overflow just wraps modulo the appropriate power of 2 (though it's undefined behaviour, so in theory it *could* do anything).
History
Date User Action Args
2015-05-13 12:42:56mark.dickinsonsetrecipients: + mark.dickinson, rhettinger, gregory.p.smith, larry, benjamin.peterson, mpm, python-dev, Matt.Mackall, serhiy.storchaka, josh.r, marmoute
2015-05-13 12:42:56mark.dickinsonsetmessageid: <1431520976.71.0.977156721835.issue23971@psf.upfronthosting.co.za>
2015-05-13 12:42:56mark.dickinsonlinkissue23971 messages
2015-05-13 12:42:56mark.dickinsoncreate