Author ncoghlan
Recipients asvetlov, gvanrossum, ncoghlan, python-dev, scoder, vstinner, yselivanov
Date 2015-05-13.06:06:45
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1431497206.0.0.747143749738.issue24017@psf.upfronthosting.co.za>
In-reply-to
Content
A bit more detail on the patch-as-merged: it has all of Yury's new tests, but the actual bug turned out to just be a missing INCREF/DECREF pair in WITH_CLEANUP_START and WITH_CLEANUP_FINISH.

In the success case the reference counting errors cancelled each other out without causing a problem, as there was always a second live reference to the exception object on the stack.

However, in the case where the awaitable threw an exception the standard exception handling machinery took care of removing the saved exception from the stack, and correctly decremented the reference count, which then caused problems due to the missing INCREF in WITH_CLEANUP_START.
History
Date User Action Args
2015-05-13 06:06:46ncoghlansetrecipients: + ncoghlan, gvanrossum, scoder, vstinner, asvetlov, python-dev, yselivanov
2015-05-13 06:06:46ncoghlansetmessageid: <1431497206.0.0.747143749738.issue24017@psf.upfronthosting.co.za>
2015-05-13 06:06:45ncoghlanlinkissue24017 messages
2015-05-13 06:06:45ncoghlancreate