Message242993
I looked at the patch again and it is in pretty good shape.
Please hoist the conditionals out of the loop (for intelligibility and to let the compiler in-line more effectively). Also, let's remove the "dump" and "clear" variable names in favor of comments that explain the conditionals (to introducing new terminology to the module).
If you want, I'll take a crack at it in the next couple of days. |
|
Date |
User |
Action |
Args |
2015-05-12 19:13:53 | rhettinger | set | recipients:
+ rhettinger, pitrou, vstinner, serhiy.storchaka |
2015-05-12 19:13:53 | rhettinger | set | messageid: <1431458033.21.0.0555199771064.issue23290@psf.upfronthosting.co.za> |
2015-05-12 19:13:53 | rhettinger | link | issue23290 messages |
2015-05-12 19:13:53 | rhettinger | create | |
|