Author ncoghlan
Recipients NeilGirdhar, Rosuav, belopolsky, berker.peksag, ethan.furman, gvanrossum, ncoghlan, python-dev, r.david.murray, rhettinger, schlamar, scoder, serhiy.storchaka, vstinner, yselivanov
Date 2015-05-08.09:24:27
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CADiSq7f1aM3uhuhBdn=sjXY0MV4FQ6TnA4Cwcyrwe7gm_+qNwQ@mail.gmail.com>
In-reply-to <CADiSq7fhS91hK+gLGLgiUte6pOrsrm1XHab0XZLwoOMTfqwMkA@mail.gmail.com>
Content
A couple of minor comments:

* "self.fail" with an appropriate error message is a clearer way to
indicate an incorrect logic path has been hit in a test case

* the details of the exception chaining don't quite look right, as I
believe "raise X from Y" sets both the cause and the context, with the
suppress_context attribute set to turn off the display of the latter. I
suggest checking that in Python code to confirm ny recollection, and then
adjusting the test and implementation if necessary to match the Python
level equivalent
History
Date User Action Args
2015-05-08 09:24:27ncoghlansetrecipients: + ncoghlan, gvanrossum, rhettinger, belopolsky, scoder, vstinner, r.david.murray, ethan.furman, python-dev, schlamar, Rosuav, berker.peksag, serhiy.storchaka, yselivanov, NeilGirdhar
2015-05-08 09:24:27ncoghlanlinkissue22906 messages
2015-05-08 09:24:27ncoghlancreate