Author ehvatum
Recipients Arfrever, Michael.Crusoe, ahonkela, benjamin.peterson, brian.curtin, christian.heimes, dhduvall, djc, drkirkby, ehvatum, jdemeyer, mdboom, merwok, rpetrov, tarek
Date 2015-05-06.20:07:54
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1430942875.11.0.868539368417.issue1222585@psf.upfronthosting.co.za>
In-reply-to
Content
The 2012-12-31 of this patch (currently the latest) has the surprising effect of causing distutils CFLAGS to be dropped.  See for reference: https://bugs.gentoo.org/show_bug.cgi?id=548776

The issue I am experiencing is resolved by changing the section of the patch that reads:

+-        (cc, cxx, opt, cflags, ccshared, ldshared, shlib_suffix, ar, ar_flags) = \
+-            get_config_vars('CC', 'CXX', 'OPT', 'CFLAGS',
+-                            'CCSHARED', 'LDSHARED', 'SHLIB_SUFFIX', 'AR', 'ARFLAGS')
++        (cc, cxx, ccshared, ldshared, ldcxxshared, shlib_suffix, ar, ar_flags) = \
++            get_config_vars('CC', 'CXX', 'CCSHARED', 'LDSHARED', 'LDCXXSHARED',
++                            'SHLIB_SUFFIX', 'AR', 'ARFLAGS')
++
++        cflags = ''
++        cxxflags = ''

to:

+-        (cc, cxx, opt, cflags, ccshared, ldshared, shlib_suffix, ar, ar_flags) = \
+-            get_config_vars('CC', 'CXX', 'OPT', 'CFLAGS',
+-                            'CCSHARED', 'LDSHARED', 'SHLIB_SUFFIX', 'AR', 'ARFLAGS')
++        (cc, cxx, cflags, ccshared, ldshared, ldcxxshared, shlib_suffix, ar, ar_flags) = \
++            get_config_vars('CC', 'CXX', 'CFLAGS', 'CCSHARED', 'LDSHARED', 'LDCXXSHARED',
++                            'SHLIB_SUFFIX', 'AR', 'ARFLAGS')
++
++        cxxflags = cflags

This change causes the CFLAGS outputted by "python-config --cflags" to be used by distutils, as they are without the patch applied.  To me, losing those CFLAGS, especially when building plain C python extensions, seems like a significant regression.
History
Date User Action Args
2015-05-06 20:07:55ehvatumsetrecipients: + ehvatum, mdboom, christian.heimes, ahonkela, benjamin.peterson, tarek, djc, merwok, rpetrov, Arfrever, brian.curtin, dhduvall, drkirkby, jdemeyer, Michael.Crusoe
2015-05-06 20:07:55ehvatumsetmessageid: <1430942875.11.0.868539368417.issue1222585@psf.upfronthosting.co.za>
2015-05-06 20:07:55ehvatumlinkissue1222585 messages
2015-05-06 20:07:54ehvatumcreate