Author maciej.szulik
Recipients BreamoreBoy, Håkan Lövdahl, barry, eric.smith, jesstess, maciej.szulik, pitrou, r.david.murray, zvyn
Date 2015-05-05.21:17:35
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1430860656.01.0.716519804151.issue21800@psf.upfronthosting.co.za>
In-reply-to
Content
David I did the review and there's one thing that worries me the most, actually two:
1. changing the usual meaning of None in the IMAP's __init__ method, where None has the same meaning as True, where I think it should be the opposite.
2. I'm not sure we want to have UTF8 enabled based on the init's flag. I've seen our IMAP library as a wrapper around protocol itself. Whereas the user must be aware of required steps needed to proceed. In this case enabling UTF8 support is just the next command the client can, but doesn't have to sent directly, but only in AUTH state.
History
Date User Action Args
2015-05-05 21:17:36maciej.szuliksetrecipients: + maciej.szulik, barry, pitrou, eric.smith, r.david.murray, jesstess, BreamoreBoy, zvyn, Håkan Lövdahl
2015-05-05 21:17:36maciej.szuliksetmessageid: <1430860656.01.0.716519804151.issue21800@psf.upfronthosting.co.za>
2015-05-05 21:17:35maciej.szuliklinkissue21800 messages
2015-05-05 21:17:35maciej.szulikcreate