Author vstinner
Recipients boya, giampaolo.rodola, loewis, pitrou, python-dev, santoso.wijaya, serhiy.storchaka, terry.reedy, vstinner, worr, zach.ware
Date 2015-04-24.22:26:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1429914400.15.0.868795997397.issue9246@psf.upfronthosting.co.za>
In-reply-to
Content
> I've updated the patch with the comments from the review

Thanks William for your contribution, I commited your fix.

I just made a minor change on "if (cwd && use_bytes) {": you forgot to remove test now useless test on cwd, and I dropped { and } to make to short more readable (Note: the PEP 7 requires to put "}" and "else {" on two lines).

Ok, I just took 5 years to get Python 2 features in Python 3 :-)
History
Date User Action Args
2015-04-24 22:26:40vstinnersetrecipients: + vstinner, loewis, terry.reedy, pitrou, giampaolo.rodola, boya, santoso.wijaya, python-dev, zach.ware, serhiy.storchaka, worr
2015-04-24 22:26:40vstinnersetmessageid: <1429914400.15.0.868795997397.issue9246@psf.upfronthosting.co.za>
2015-04-24 22:26:40vstinnerlinkissue9246 messages
2015-04-24 22:26:39vstinnercreate