Author martin.panter
Recipients berker.peksag, martin.panter, milap.py, python-dev, r.david.murray, serhiy.storchaka, taddeimania
Date 2015-04-16.03:35:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1429155309.71.0.881223006099.issue23883@psf.upfronthosting.co.za>
In-reply-to
Content
Oh I see, TarIter is listed underneath a comment saying “Exported Classes”, and main() is listed underneath “exported functions”. If they are indeed meant to be exported, they should probably also be documented. Otherwise, maybe we can just add another comment clarifying that they are internal.

In the latest patch, I think HeaderError should be added back to __all__; it is just its subclasses that are not documented. Also XHDTYPE is listed twice in the test case.

If it were up to me, I would add the TarInfo.type constants (REGTYPE, AREGTYPE, LNKTYPE, SYMTYPE, DIRTYPE, FIFOTYPE, CONTTYPE, CHRTYPE, BLKTYPE, GNUTYPE_SPARSE). But I’m not sure if others would agree.
History
Date User Action Args
2015-04-16 03:35:09martin.pantersetrecipients: + martin.panter, r.david.murray, python-dev, berker.peksag, serhiy.storchaka, milap.py, taddeimania
2015-04-16 03:35:09martin.pantersetmessageid: <1429155309.71.0.881223006099.issue23883@psf.upfronthosting.co.za>
2015-04-16 03:35:09martin.panterlinkissue23883 messages
2015-04-16 03:35:09martin.pantercreate