Author flipmcf
Recipients BreamoreBoy, Rodrigue.Alcazar, bobcatfish, ezio.melotti, flipmcf, michael.foord, ncoghlan, pitrou, r.david.murray
Date 2015-04-15.14:28:49
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1429108129.36.0.0999255225173.issue9517@psf.upfronthosting.co.za>
In-reply-to
Content
> I'm thinking also, maybe instead of putting script_helper into the
> test.support namespace, we could move the individual methods and
> helpers from script_helper into test.support, e.g.:
>
> test.support.run_python_until_end
> vs.
> test.support.script_helper.run_python_until_end1

Yes, I also agree that this looks better.

But as this was first humble patch submission to CPython, I followed David Murry's instructions during my review - which was to move the entire module. 

I would be opposed to adding the methods directly into __init__.py, 

I would recommend still moving script_helper into test.support , and adding a list of symbols from script_helper.py into __init__

eg:

test/support/__init__.py:
  from script_helper import run_python_until_end

test/some_test.py:
  from test.support import run_python_until_end

I am currently in the PyCon CPython sprint room if you are also here.
History
Date User Action Args
2015-04-15 14:28:49flipmcfsetrecipients: + flipmcf, ncoghlan, pitrou, ezio.melotti, r.david.murray, michael.foord, BreamoreBoy, Rodrigue.Alcazar, bobcatfish
2015-04-15 14:28:49flipmcfsetmessageid: <1429108129.36.0.0999255225173.issue9517@psf.upfronthosting.co.za>
2015-04-15 14:28:49flipmcflinkissue9517 messages
2015-04-15 14:28:49flipmcfcreate