Author martin.panter
Recipients Jeff.Edwards, Stephen.Day, cvrebert, eric.araujo, ezio.melotti, jin, maker, martin.panter, orsenthil, ronnix, samwyse, wiggin15
Date 2015-04-15.11:17:46
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1429096666.28.0.946946750376.issue13866@psf.upfronthosting.co.za>
In-reply-to
Content
To be consistent, I think the documentation should mark up the parameters with asterisks: *quote_via*. Also, you lost the markup for :func:`quote_plus`.

The test cases should probably use self.assertEqual(). The “assert” statement is not appropriate for testing because it can be optimized away.

You also need to clarify in the documentation and tests how the “safe” parameter interacts with the choice of quote function. Are slashes encoded or not by default with quote_via=quote?
History
Date User Action Args
2015-04-15 11:17:46martin.pantersetrecipients: + martin.panter, orsenthil, samwyse, ezio.melotti, eric.araujo, cvrebert, maker, wiggin15, ronnix, Stephen.Day, jin, Jeff.Edwards
2015-04-15 11:17:46martin.pantersetmessageid: <1429096666.28.0.946946750376.issue13866@psf.upfronthosting.co.za>
2015-04-15 11:17:46martin.panterlinkissue13866 messages
2015-04-15 11:17:46martin.pantercreate