Author demian.brecht
Recipients demian.brecht, martin.panter, pitrou
Date 2015-04-14.04:42:29
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1428986549.41.0.708049374246.issue23377@psf.upfronthosting.co.za>
In-reply-to
Content
> I think it's ok to slightly break a non-public API since it's required to fix an obvious bug.

To play devil's advocate here, /is/ this really non-public API? According to documented Python naming conventions, HTTPResponse is part of the public API. From code I've written myself, this would likely create a number of breakages. Granted, it would largely be in lower level testing code, but it would still create a headache. Is something that's lightly documented as being non-public take precedence over well known and used naming conventions? I'd argue no, it shouldn't.

That said, I'm not overly enthused about the alternative Martin describes, so at first thought, I'm pretty much square on the fence about this.

> By the way, I guess we don't support HTTP pipelining, right?

As Martin pointed out, sadly no. There's currently an internal state machine that seems to possibly be remnants of an initial implementation (just a guess, I haven't done any research into it to prove that though) that prevents pipelining. It's on my list of things to tackle as it seems to be a natural progression to HTTP/2.0 multiplexing, but unfortunately my time is a little shorter than usual at the moment (taking a new job has cut into my spare time a little).

@Martin:

I haven't had a chance to review the change in detail yet, but I think the idea's sound. I'll try to get some time over the next few days to dig into it further.
History
Date User Action Args
2015-04-14 04:42:29demian.brechtsetrecipients: + demian.brecht, pitrou, martin.panter
2015-04-14 04:42:29demian.brechtsetmessageid: <1428986549.41.0.708049374246.issue23377@psf.upfronthosting.co.za>
2015-04-14 04:42:29demian.brechtlinkissue23377 messages
2015-04-14 04:42:29demian.brechtcreate