➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author berker.peksag
Recipients Dhara, berker.peksag, copper-head, ezio.melotti, michael.foord
Date 2015-04-13.20:56:01
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1428958561.97.0.475629241409.issue20362@psf.upfronthosting.co.za>
In-reply-to
Content 
Thanks for the patches, Ilia. The one for 2.7 looks good.

Reviewing 20362_py35.patch:

* Looks almost identical to issue20362.diff except style changes and the two comments below, right?

* -            self.assertIn("'kot'", e.args[0])

  Why did you remove this line?

* +    assertNotRegexpMatches = _deprecate(assertNotRegex)

  This looks like an unrelated change, but I think it can be committed. Thanks for the catch!

* The tests should be updated to use assertRegex and assertNotRegex
History
Date User Action Args
2015-04-13 20:56:02berker.peksagsetrecipients: + berker.peksag, ezio.melotti, michael.foord, Dhara, copper-head
2015-04-13 20:56:01berker.peksagsetmessageid: <1428958561.97.0.475629241409.issue20362@psf.upfronthosting.co.za>
2015-04-13 20:56:01berker.peksaglinkissue20362 messages
2015-04-13 20:56:01berker.peksagcreate