Author vstinner
Recipients alex, benjamin.peterson, piotr.dobrogost, pitrou, serhiy.storchaka, stutzbach, vstinner
Date 2015-04-10.07:52:08
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1428652328.52.0.362436936208.issue21859@psf.upfronthosting.co.za>
In-reply-to
Content
> Slightly corrected docstrings (but for larger changes C and Python implementations should be changed consistently).

I reviewed pyio_fileio_9.patch. The main issue is that I don't understand how self._fd is set to None. In the C implemented, it's set to -1 even if closefd is False.

For comments on docstrings which also concern the C code, can you maybe open a new issue with a reference to this issue or maybe even a link to my review, if you don't want to modify them in this issue?
History
Date User Action Args
2015-04-10 07:52:08vstinnersetrecipients: + vstinner, pitrou, benjamin.peterson, stutzbach, alex, piotr.dobrogost, serhiy.storchaka
2015-04-10 07:52:08vstinnersetmessageid: <1428652328.52.0.362436936208.issue21859@psf.upfronthosting.co.za>
2015-04-10 07:52:08vstinnerlinkissue21859 messages
2015-04-10 07:52:08vstinnercreate