Message239831
Thanks for the feedback, Berker!
I've added a test case that closes a buffered reader and then attempts to both peek and read1 it. I tacked it onto the end of the BufferedReaderTest class in test_io, but let me know if there's a better place to put it.
I've also added the check to read1 -- good catch. I opted to add it before the check that the argument to read1 is 0 -- my assumption is that a 0-length read on a closed BufferReader should fail, not return an empty bytestring.
Thanks again for the feedback! |
|
Date |
User |
Action |
Args |
2015-04-01 17:49:52 | jdherg | set | recipients:
+ jdherg, vstinner, berker.peksag, martin.panter, serhiy.storchaka |
2015-04-01 17:49:52 | jdherg | set | messageid: <1427910592.51.0.431277891558.issue23796@psf.upfronthosting.co.za> |
2015-04-01 17:49:52 | jdherg | link | issue23796 messages |
2015-04-01 17:49:52 | jdherg | create | |
|