Message239667
Thank you for your review Berker.
> Is there a reason not to use assertWarnsRegex?
Initially the patch was written for 2.7. Fixing WeakValueDictionary in 2.7
needs first fix UserDict (issue22958). That is why I returned to this issue.
> Also, there are already collections.UserDict() usages in the test file, so
> I'd remove the "from collections import UserDict" import.
These tests originally was written for test_collections.
Updated patch addresses Berker's comment. |
|
Date |
User |
Action |
Args |
2015-03-31 05:28:51 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, rhettinger, mark.dickinson, larry, abacabadabacaba, ethan.furman, python-dev, berker.peksag |
2015-03-31 05:28:50 | serhiy.storchaka | link | issue22609 messages |
2015-03-31 05:28:50 | serhiy.storchaka | create | |
|