Author dstufft
Recipients benjamin.peterson, berker.peksag, dstufft, r.david.murray
Date 2015-03-29.20:31:41
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1427661102.22.0.329446702944.issue23801@psf.upfronthosting.co.za>
In-reply-to
Content
@Benjamin

The reason I didn't do that to begin with, was the code currently checks if the first line is a bytes object or not in order to be able to raise an error if it's returning str instead of bytes. I didn't want to redo that check on every iteration, so I left the original part alone and then used the while loop to handle doing more if needed.

Would you prefer the code written your way and either drop the bytes check or incur the cost of doing the type check on every line?
History
Date User Action Args
2015-03-29 20:31:42dstufftsetrecipients: + dstufft, benjamin.peterson, r.david.murray, berker.peksag
2015-03-29 20:31:42dstufftsetmessageid: <1427661102.22.0.329446702944.issue23801@psf.upfronthosting.co.za>
2015-03-29 20:31:42dstufftlinkissue23801 messages
2015-03-29 20:31:41dstufftcreate