Author petr.viktorin
Recipients ethan.furman, petr.viktorin, serhiy.storchaka, skrah
Date 2015-03-20.14:33:30
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1426862010.16.0.447674039696.issue23699@psf.upfronthosting.co.za>
In-reply-to
Content
Making it a function might help with the following issues:
- series of comparisons and PyBool_FromLong is less efficient than switch and Py_RETURN_*. But it would add a function call.
- it might be too complex for a macro

Do you think that would help?

As for the signature, I would like this to mirror richcmpfunc and PyObject_RichCompareBool. And returning PyObjexct*, not 0/1, is an important part of reducing boilerplate; in cases where 0/1 would be helpful you can easily work with cmp-style -1/0/1 values before using this to convert them.
History
Date User Action Args
2015-03-20 14:33:30petr.viktorinsetrecipients: + petr.viktorin, skrah, ethan.furman, serhiy.storchaka
2015-03-20 14:33:30petr.viktorinsetmessageid: <1426862010.16.0.447674039696.issue23699@psf.upfronthosting.co.za>
2015-03-20 14:33:30petr.viktorinlinkissue23699 messages
2015-03-20 14:33:30petr.viktorincreate