Author martin.panter
Recipients Arfrever, berker.peksag, ezio.melotti, martin.panter, rhettinger, serhiy.storchaka, vstinner
Date 2015-03-20.12:36:25
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1426854985.87.0.777793725937.issue22831@psf.upfronthosting.co.za>
In-reply-to
Content
There were a couple mistakes I found; see Reitveld. I was going to say to leave the open(mode="r") parameter as it is, since an explicit "r" is more readable, but since you already took some out, I’m not going to complain.

While many of the changes look worthwhile, I do worry that some of them will never be tested (at least until say Python 3.14 or something). E.g. I just tried running Tools/scripts/dutree.py cos it looked interesting, but was confronted with the “unorderable types: int() < NoneType()” Python 2-ism.
History
Date User Action Args
2015-03-20 12:36:25martin.pantersetrecipients: + martin.panter, rhettinger, vstinner, ezio.melotti, Arfrever, berker.peksag, serhiy.storchaka
2015-03-20 12:36:25martin.pantersetmessageid: <1426854985.87.0.777793725937.issue22831@psf.upfronthosting.co.za>
2015-03-20 12:36:25martin.panterlinkissue22831 messages
2015-03-20 12:36:25martin.pantercreate