This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients python-dev, vstinner
Date 2015-03-20.11:24:27
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1426850667.3.0.162673105135.issue23708@psf.upfronthosting.co.za>
In-reply-to
Content
> New changeset 07fd54208434 by Victor Stinner in branch 'default':
> Issue #23708: Save/restore errno in _Py_read() and _Py_write()

When I wrote _Py_read()/_Py_write(), I added assertions on errno to ensure that errno is not modified. I chose to use assertions instead of save/restore errno because on Linux errno is not modified. Since they *are* platforms where errno is modified, it's safer to always save/restore errno.

_Py_read()/_Py_write() *must* set set errno because some callers uses it. It's more convinient to use errno than having to get the errno attribute of the raised OSError exception.

test_signal pass again on "AMD64 Snow Leop 3.x" buildbot, I close the issue.
History
Date User Action Args
2015-03-20 11:24:27vstinnersetrecipients: + vstinner, python-dev
2015-03-20 11:24:27vstinnersetmessageid: <1426850667.3.0.162673105135.issue23708@psf.upfronthosting.co.za>
2015-03-20 11:24:27vstinnerlinkissue23708 messages
2015-03-20 11:24:27vstinnercreate