Message238602
Looks good. A couple of comments:
* Doc/includes/email-* changes have already been committed.
* There is a commented-out line in Tools/scripts/nm2def.py:
- f.close()
+ # f.close()
* The patch is huge, I'd commit Tools/ and Lib/test/ parts separately.
* Most of the open(..., 'r') usages can be changed to open(...)
* It would be good to add context management protocol support to http.client.HTTPConnection. |
|
Date |
User |
Action |
Args |
2015-03-20 03:30:02 | berker.peksag | set | recipients:
+ berker.peksag, rhettinger, ezio.melotti, Arfrever, martin.panter, serhiy.storchaka |
2015-03-20 03:30:02 | berker.peksag | set | messageid: <1426822202.36.0.887116341318.issue22831@psf.upfronthosting.co.za> |
2015-03-20 03:30:02 | berker.peksag | link | issue22831 messages |
2015-03-20 03:30:02 | berker.peksag | create | |
|