Author vstinner
Recipients loewis, pitrou, steve.dower, tim.golden, twouters, vstinner, zach.ware
Date 2015-03-17.15:44:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1426607054.07.0.158839985643.issue23685@psf.upfronthosting.co.za>
In-reply-to
Content
"I don't think we should be using PyMODINIT_FUNC for builtin modules, since that will make the init functions publicly available from python35.dll."

Do you mean that my change on PC/config.c is wrong?

For example, Modules/arraymodule.c already contains:

"PyMODINIT_FUNC PyInit_array(void)".

Is the PyInit_array symbol exported today or not on Windows?

If you think that the PyInit_array symbol should be private, maybe there is already an issue in Modules/arraymodule.c?

"can we define PyMODINIT_FUNC differently when building pythoncore?"

We can add a different macro for builtin modules. Using the issue #11410, we may use it to hide the symbols: __attribute__((visibility("hidden"))).
History
Date User Action Args
2015-03-17 15:44:14vstinnersetrecipients: + vstinner, loewis, twouters, pitrou, tim.golden, zach.ware, steve.dower
2015-03-17 15:44:14vstinnersetmessageid: <1426607054.07.0.158839985643.issue23685@psf.upfronthosting.co.za>
2015-03-17 15:44:14vstinnerlinkissue23685 messages
2015-03-17 15:44:14vstinnercreate