Author vstinner
Recipients benhoyt, python-dev, scott.dial, serhiy.storchaka, vstinner
Date 2015-03-13.10:37:53
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1426243073.89.0.00873686546561.issue23605@psf.upfronthosting.co.za>
In-reply-to
Content
I don't understand your benchmark. Do you mean that os.walk() is slower with fast_bottom-up.patch because islink() is called or because I replaced "for entry in scandir(top):" with "entry = next(scandir_it)"?

Are you testing the top-bottom or bottom-up?

Here is a variant of my patch with "for entry in scandir(top):". I would prefer to avoid this variant with a boolean to not catch OSError on the recursive call to walk() if next() has similar performances.
History
Date User Action Args
2015-03-13 10:37:53vstinnersetrecipients: + vstinner, scott.dial, benhoyt, python-dev, serhiy.storchaka
2015-03-13 10:37:53vstinnersetmessageid: <1426243073.89.0.00873686546561.issue23605@psf.upfronthosting.co.za>
2015-03-13 10:37:53vstinnerlinkissue23605 messages
2015-03-13 10:37:53vstinnercreate