Message237940
> Let me know if there is possible further improvement in this patch.
I was going to push your change, but I noticed that you use stderr.fileno() in tests. I modified the test to use a different file descriptor. sys.stderr is also the default value, so the test may pass because the file descriptor was ignored (if there was a bug in your change, which is not the case).
I pushed the modified patch.
Thanks for your contribution Wei Wu! |
|
Date |
User |
Action |
Args |
2015-03-12 14:36:01 | vstinner | set | recipients:
+ vstinner, python-dev, sigi, kilowu |
2015-03-12 14:36:01 | vstinner | set | messageid: <1426170961.82.0.536537431885.issue23566@psf.upfronthosting.co.za> |
2015-03-12 14:36:01 | vstinner | link | issue23566 messages |
2015-03-12 14:36:01 | vstinner | create | |
|