Author vstinner
Recipients benhoyt, python-dev, scott.dial, serhiy.storchaka, vstinner
Date 2015-03-10.15:48:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAMpsgwZ9E5bp-gqiv5ZfOndSLJwT5tGeA=tKOt31EDDb9yoLAA@mail.gmail.com>
In-reply-to <1426001649.86.0.41117081211.issue23605@psf.upfronthosting.co.za>
Content
Serhiy Storchaka added the comment:
> When followlinks is true, symlinks is not needed.

Hum, it's not easy to understand your code. I guess that the problem
is that a symlink to a directory can become something else (not a
directory or a symlink to a directory).

I noticed this race condition in the new implementation of os.walk(),
but I don't think that the issue is really new. The old implementation
of os.walk() already uses a list of directories. The caller can remove
a directory or replace a directory with something else.

Since the bug is not documented in os.walk(), I chose to not document
it neither. But it would be better to warn users to not do that :-)

@Serhiy: I agree that the new implementation changes the behaviour,
but I don't consider it as as bug. Do you think that it's a bug?
History
Date User Action Args
2015-03-10 15:48:15vstinnersetrecipients: + vstinner, scott.dial, benhoyt, python-dev, serhiy.storchaka
2015-03-10 15:48:15vstinnerlinkissue23605 messages
2015-03-10 15:48:15vstinnercreate