This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients larry, python-dev, serhiy.storchaka, steve.dower, tim.golden, vstinner, zach.ware
Date 2015-03-08.02:29:24
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
fstat_ebadf.patch: _Py_fstat() now also set errno on Windows.

It's a little bit different than your patch, because it still calls SetLastError(ERROR_INVALID_HANDLE) to explicitly set the Windows error on bad file descriptor. We must set errno et SetLastError(): some callers check for errno, some callers uses GetLastError() (ex: path_error()).

I don't have access to Windows right now, I cannot test the patch. And it's maybe safer to wait after Python 3.5 alpha 2 release to apply it, if your latest change is enough to fix test_os on Windows.
Date User Action Args
2015-03-08 02:29:24vstinnersetrecipients: + vstinner, larry, tim.golden, python-dev, zach.ware, serhiy.storchaka, steve.dower
2015-03-08 02:29:24vstinnersetmessageid: <>
2015-03-08 02:29:24vstinnerlinkissue23524 messages
2015-03-08 02:29:24vstinnercreate