Message237502
fstat_ebadf.patch: _Py_fstat() now also set errno on Windows.
It's a little bit different than your patch, because it still calls SetLastError(ERROR_INVALID_HANDLE) to explicitly set the Windows error on bad file descriptor. We must set errno et SetLastError(): some callers check for errno, some callers uses GetLastError() (ex: path_error()).
I don't have access to Windows right now, I cannot test the patch. And it's maybe safer to wait after Python 3.5 alpha 2 release to apply it, if your latest change is enough to fix test_os on Windows. |
|
Date |
User |
Action |
Args |
2015-03-08 02:29:24 | vstinner | set | recipients:
+ vstinner, larry, tim.golden, python-dev, zach.ware, serhiy.storchaka, steve.dower |
2015-03-08 02:29:24 | vstinner | set | messageid: <1425781764.86.0.140068123931.issue23524@psf.upfronthosting.co.za> |
2015-03-08 02:29:24 | vstinner | link | issue23524 messages |
2015-03-08 02:29:24 | vstinner | create | |
|