Author Hisham Muhammad
Recipients Hisham Muhammad
Date 2015-03-02.16:50:12
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
In Modules/_posixsubprocess.c, (the helper module for Lib/ there's a function called _sanity_check_python_fd_sequence which checks, as its comment says, if the fds in the sequence are all positive and sorted.

The check to verify if it is sorted is incorrect (missing the update to the prev_fd variable), and also it is missing a test to see if fd's are repeated (which they shouldn't be, so the test should use <= rather than <). 

The attached patch, written against Python 3.4.3 source code, fixes it.
Date User Action Args
2015-03-02 16:50:12Hisham Muhammadsetrecipients: + Hisham Muhammad
2015-03-02 16:50:12Hisham Muhammadsetmessageid: <>
2015-03-02 16:50:12Hisham Muhammadlinkissue23564 messages
2015-03-02 16:50:12Hisham Muhammadcreate