Author jimr
Recipients demian.brecht, jimr
Date 2015-02-27.19:24:27
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1425065067.95.0.199328478814.issue23539@psf.upfronthosting.co.za>
In-reply-to
Content
OK, I've got a patch but it's failing on 'test_send_file'[1], which is sending a body on a GET request. According to the IETF memo[2]:

   Bodies on GET requests have no defined semantics.  Note that sending
   a body on a GET request might cause some existing implementations to
   reject the request.

So I don't know whether to remove the method constraint so this test passes, or to "fix" this test to use a different method. My feeling is that stripping out Content-Length for GET requests could cause problems for some code that for whatever reason uses this, so we should remove that constraint (it was only "SHOULD NOT" after all) and go back to the original proposal of just setting the content length for bodies that are None as well as empty strings.

[1] https://hg.python.org/cpython/file/325aec842e3e/Lib/test/test_httplib.py#l297
[2] http://tools.ietf.org/html/draft-ietf-httpbis-p2-semantics-14#section-7.3
History
Date User Action Args
2015-02-27 19:24:27jimrsetrecipients: + jimr, demian.brecht
2015-02-27 19:24:27jimrsetmessageid: <1425065067.95.0.199328478814.issue23539@psf.upfronthosting.co.za>
2015-02-27 19:24:27jimrlinkissue23539 messages
2015-02-27 19:24:27jimrcreate