Message236811
New patch, which should cover all the other uses of _PyVerify_fd outside of posixmodule.
I've moved _PyVerify_fd into fileutils (but left _PyVerify_fd_dup2 in posixmodule, as it's basically deprecated at this point).
_Py_VERIFY_FD is now in fileutils.h, and is used everywhere it makes sense. I also fixed up some error handling for _Py_fstat that was using errno on Windows rather than GetLastError() - I can split this into a separate issue if it's in the way.
_Py_BEGIN/END_SUPPRESS_IPH are now in pymacro.h as they need to be after PyAPI_DATA is defined - the silent invalid parameter handler is now defined in PC/invalid_parameter_handler.c but setting and restoring it need to be in macros.
Builds are fine on VS 2015 CTP 6 (with this code enabled) and VS 2013 (with the old code enabled), and I'm getting set up to test a Linux build with the patch. |
|
Date |
User |
Action |
Args |
2015-02-27 18:33:52 | steve.dower | set | recipients:
+ steve.dower, vstinner, larry, tim.golden, zach.ware, serhiy.storchaka |
2015-02-27 18:33:51 | steve.dower | set | messageid: <1425062031.58.0.200756586914.issue23524@psf.upfronthosting.co.za> |
2015-02-27 18:33:51 | steve.dower | link | issue23524 messages |
2015-02-27 18:33:51 | steve.dower | create | |
|