➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author martin.panter
Recipients DragonFireCK, amaury.forgeotdarc, benjamin.peterson, brandjon, dangyogi, daniel.urban, georg.brandl, gpolo, hagen, kcarnold, martin.panter, ncoghlan, pfctdayelise, pitrou, r.david.murray, ron_adam, terry.reedy
Date 2015-02-24.04:29:12
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1424752154.2.0.471173353395.issue4806@psf.upfronthosting.co.za>
In-reply-to
Content 
I am posting a new version of Daniel’s patch as issue4806-star-TypeError.v2.patch:

* Merged with recent “default” (3.5) branch
* Dropped the documentation fix, since revision a8aa918041c2 already fixed that in an identical fashion
* Changed to a “look before you leap” style check before attempting PySequence_Tuple(). This way we get to keep other valid errors such as “iter() returned non-iterator”.

I am comfortable with the code changes previous patch as well as mine. Checking the “tp_iter” field and PySequence_Check() is basically what happens behind the scenes, via PyObject_GetIter() anyway. So I think either patch is valid and a worthwhile improvement.
History
Date User Action Args
2015-02-24 04:29:14martin.pantersetrecipients: + martin.panter, georg.brandl, terry.reedy, amaury.forgeotdarc, ncoghlan, pitrou, ron_adam, dangyogi, benjamin.peterson, gpolo, hagen, kcarnold, r.david.murray, daniel.urban, pfctdayelise, brandjon, DragonFireCK
2015-02-24 04:29:14martin.pantersetmessageid: <1424752154.2.0.471173353395.issue4806@psf.upfronthosting.co.za>
2015-02-24 04:29:14martin.panterlinkissue4806 messages
2015-02-24 04:29:13martin.pantercreate