This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author steve.dower
Recipients benjamin.peterson, hynek, josh.r, pitrou, python-dev, steve.dower, stutzbach, tim.golden, vstinner, zach.ware
Date 2015-02-21.17:53:42
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1424541223.21.0.745481057522.issue23152@psf.upfronthosting.co.za>
In-reply-to
Content
The caller to getfilesize is only using it to check whether it's small enough to load the file into memory all at once, so "too big" is an okay response (that function is in marshal.c and not used anywhere else).

The error label just returns back to the interpreter loop, previously without an exception set, so we got a SystemError. I mentioned this in my first post.

Happy to rename the now shared functions - I just took those straight from your patch :)
History
Date User Action Args
2015-02-21 17:53:43steve.dowersetrecipients: + steve.dower, pitrou, vstinner, tim.golden, benjamin.peterson, stutzbach, python-dev, hynek, zach.ware, josh.r
2015-02-21 17:53:43steve.dowersetmessageid: <1424541223.21.0.745481057522.issue23152@psf.upfronthosting.co.za>
2015-02-21 17:53:43steve.dowerlinkissue23152 messages
2015-02-21 17:53:42steve.dowercreate