Message 236131 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	martius
Recipients	gvanrossum, martius, vstinner, yselivanov
Date	2015-02-17.11:38:58
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1424173139.03.0.812123620272.issue21998@psf.upfronthosting.co.za>
In-reply-to

Content
I read the patch, it looks good to me for python 3.5. It will (obviously) not work with python 3.4 since self._selector won't have an _at_fork() method. I ran the tests on my project with python 3.5a1 and the patch, it seems to work as expected: ie. when I close the loop of the parent process in the child, it does not affect the parent. I don't have a case where the loop of the parent is still used in the child though.

I read the patch, it looks good to me for python 3.5. It will (obviously) not work with python 3.4 since self._selector won't have an _at_fork() method.

I ran the tests on my project with python 3.5a1 and the patch, it seems to work as expected: ie. when I close the loop of the parent process in the child, it does not affect the parent.

I don't have a case where the loop of the parent is still used in the child though.

History
Date	User	Action	Args
2015-02-17 11:38:59	martius	set	recipients: + martius, gvanrossum, vstinner, yselivanov
2015-02-17 11:38:59	martius	set	messageid: <1424173139.03.0.812123620272.issue21998@psf.upfronthosting.co.za>
2015-02-17 11:38:58	martius	link	issue21998 messages
2015-02-17 11:38:58	martius	create