Message235300
Third version of the patch (subprocess_run3):
- Simplifies the documentation of the trio (call, check_call, check_output) to describe them in terms of the equivalent run() call.
- Remove a warning about using PIPE with check_output - I believe this was already incorrect, since check_output uses .communicate() internally, it shouldn't have deadlock issues.
- Replace the implementation of check_output() with a call to run().
I didn't reimplement call or check_call - as previously discussed, they are more different from the code in run(), so subtly breaking things is more possible. They are also simpler. |
|
Date |
User |
Action |
Args |
2015-02-02 23:19:13 | takluyver | set | recipients:
+ takluyver, barry, gregory.p.smith, r.david.murray, ethan.furman, martin.panter |
2015-02-02 23:19:13 | takluyver | set | messageid: <1422919153.57.0.791574261029.issue23342@psf.upfronthosting.co.za> |
2015-02-02 23:19:13 | takluyver | link | issue23342 messages |
2015-02-02 23:19:13 | takluyver | create | |
|