Message234860
FYI I opened a thread about this issue on the Tulip mailing list.
Antoine Pitrou added the comment:
> IMO, connection_lost() should never be called if connection_made() wasn't called. That's a breach of the API contract.
Yes, I agree.
> (at one point, I suggested a connection_failed() for that purpose, but it was shut down - it was in relationship to the idea of a reconnecting client, but can still be more broadly useful)
I like the "connection_failed" name. We may call
protocol.connection_failed(transport), so the protocol gets access to
the socket and so to the IP addres. |
|
Date |
User |
Action |
Args |
2015-01-27 22:47:06 | vstinner | set | recipients:
+ vstinner, gvanrossum, pitrou, yselivanov |
2015-01-27 22:47:06 | vstinner | link | issue23333 messages |
2015-01-27 22:47:06 | vstinner | create | |
|