Author demian.brecht
Recipients demian.brecht, martin.panter, neologix, pitrou
Date 2015-01-23.06:47:04
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1421995626.84.0.679064552226.issue23302@psf.upfronthosting.co.za>
In-reply-to
Content
I've attached a new patch disabling Nagle by default, but doing so in connect() as to allow users to override it if they really want to. I've also removed the use of mss in HTTPConnection. This is a backwards incompatible change in two ways:

1. Removing mss as a public attribute of the HTTPConnection. This /could/ be left as a property that pulls the TCP_MAXSEG option once a connection has been established, but I think it's better to just remove it altogether and have the users call into <HTTPConnection>.sock.getsockopt() instead.
2. If someone is expecting to be able to rely on Nagle by default, although I think this is rather unlikely for HTTP.

That said, I do agree that this is a simpler, more portable choice to solve the problem.
History
Date User Action Args
2015-01-23 06:47:07demian.brechtsetrecipients: + demian.brecht, pitrou, neologix, martin.panter
2015-01-23 06:47:06demian.brechtsetmessageid: <1421995626.84.0.679064552226.issue23302@psf.upfronthosting.co.za>
2015-01-23 06:47:06demian.brechtlinkissue23302 messages
2015-01-23 06:47:06demian.brechtcreate