Message234473
I answered my Q1 in msg187219: test.test_gettest is currently passing, with no skips, on 2.7 and 3.4 on Win 7.
patch.diff: I would rather add the 4 lines of the proposed idle_i18n.py to an existing module, perhaps Bindings.py itself, since that is the first place _ will be used. I think +-60 modules is already too many.
The binding of '_' to gettext.gettext conflicts with the somewhat common use of '_' as a dummy identifier. I do not know of any such uses in idlelib, but there might be. There are about 4500 lines in idlelib with '_'; too many to review. Someone should do a more refined search with an re that excludes '_' preceded or followed by an identifier char, to skip '__xyz__' or '_x' or 'y_'.
If '_ is used for gettest, a new rule to not otherwise bind '_' should be added the currently non-existent Idle maintainer guide.
patch2.tar.gz is not readable by Rietveld, Firefox, IE, or Windows. Patches should be uploaded as plaintext.diff or .patch.
Damien: Contributors must submit a signed Contributor Agreement. See https://www.python.org/psf/contrib/ and https://www.python.org/psf/contrib/contrib-form/ (the online form). Please do this even before re-uploading patch2. Receipt and acceptance of a form is acknowledged by addition of an * after "Author: nick(real name)". |
|
Date |
User |
Action |
Args |
2015-01-22 05:20:03 | terry.reedy | set | recipients:
+ terry.reedy, pitrou, ned.deily, ezio.melotti, roger.serwy, Todd.Rovito, Al.Sweigart, olberger, mariedam |
2015-01-22 05:20:03 | terry.reedy | set | messageid: <1421904003.03.0.907406797335.issue17776@psf.upfronthosting.co.za> |
2015-01-22 05:20:02 | terry.reedy | link | issue17776 messages |
2015-01-22 05:20:01 | terry.reedy | create | |
|