Author serhiy.storchaka
Recipients ncoghlan, pmoody, serhiy.storchaka
Date 2015-01-18.20:02:38
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1421611358.75.0.717594852846.issue23268@psf.upfronthosting.co.za>
In-reply-to
Content
Here is a patch which fixes following errors in comparison of ipaddress classes.

1. Ordering comparison raised AttributeError when compared with foreign classes.

2. Ordering comparison didn't return NotImplemented when compared with foreign classes. This prevented fallback to foreign class comparison method.

3. There was a bug in _TotalOrderingMixin.__le__(). It could return False instead of NotImplemented if compared network and address of different versions.

4. There was a typo in ComparisonTests.test_incompatible_versions().

As far as functools.total_ordering now is fixed and more correct and tested than _TotalOrderingMixin, _TotalOrderingMixin is dropped away.
History
Date User Action Args
2015-01-18 20:02:38serhiy.storchakasetrecipients: + serhiy.storchaka, ncoghlan, pmoody
2015-01-18 20:02:38serhiy.storchakasetmessageid: <1421611358.75.0.717594852846.issue23268@psf.upfronthosting.co.za>
2015-01-18 20:02:38serhiy.storchakalinkissue23268 messages
2015-01-18 20:02:38serhiy.storchakacreate