Message234239
I found the code used to collapse addresses to be very slow on a large number (64k) of island addresses which are not collapseable.
The code at
https://github.com/python/cpython/blob/0f164ccc85ff055a32d11ad00017eff768a79625/Lib/ipaddress.py#L349
was found to be guilty, especially the index lookup.
The patch changes the code to discard the index lookup and have _find_address_range return the number of items consumed.
That way the set operation to dedup the addresses can be dropped as well.
Numbers from the testrig I adapted from http://bugs.python.org/issue20826 with 8k non-consecutive addresses:
Execution time: 0.6893927365541458 seconds
vs.
Execution time: 12.116527611762285 seconds
MfG
Markus Kötter |
|
Date |
User |
Action |
Args |
2015-01-18 12:32:34 | cmn | set | recipients:
+ cmn |
2015-01-18 12:32:34 | cmn | set | messageid: <1421584354.17.0.398119389429.issue23266@psf.upfronthosting.co.za> |
2015-01-18 12:32:34 | cmn | link | issue23266 messages |
2015-01-18 12:32:34 | cmn | create | |
|