Author cmn
Recipients cmn
Date 2015-01-18.12:32:33
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1421584354.17.0.398119389429.issue23266@psf.upfronthosting.co.za>
In-reply-to
Content
I found the code used to collapse addresses to be very slow on a large number (64k) of island addresses which are not collapseable.

The code at
https://github.com/python/cpython/blob/0f164ccc85ff055a32d11ad00017eff768a79625/Lib/ipaddress.py#L349
was found to be guilty, especially the index lookup.
The patch changes the code to discard the index lookup and have _find_address_range return the number of items consumed.
That way the set operation to dedup the addresses can be dropped as well.

Numbers from the testrig I adapted from http://bugs.python.org/issue20826 with 8k non-consecutive addresses:

Execution time: 0.6893927365541458 seconds
vs.
Execution time: 12.116527611762285 seconds


MfG
Markus Kötter
History
Date User Action Args
2015-01-18 12:32:34cmnsetrecipients: + cmn
2015-01-18 12:32:34cmnsetmessageid: <1421584354.17.0.398119389429.issue23266@psf.upfronthosting.co.za>
2015-01-18 12:32:34cmnlinkissue23266 messages
2015-01-18 12:32:34cmncreate