Author steve.dower
Recipients brian.curtin, giampaolo.rodola, jkloth, lemburg, loewis, pitrou, serhiy.storchaka, steve.dower, tim.golden, tim.peters, zach.ware
Date 2014-12-31.18:59:04
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1420052346.12.0.0144530204378.issue19143@psf.upfronthosting.co.za>
In-reply-to
Content
I've attached a replacement for the win32_ver function in platform.py that will get the actual version number from kernel32.dll's resources. Originally I was just writing a helper function, but it seemed easy enough to replace the entire function.

The attached function only really supports Python 3.5 as it assumes that the earliest Windows version will be Vista (6.0). The comments in platform.py suggest backwards compatibility is important for this file, so my win32_ver() may be a better reference for someone who wants to add this functionality in a backwards-compatible way. Though if it's okay for the stdlib platform.py to not support pre-3.5 this should be fine (and I'll do the extra work to make sure).

It's probably also easy to support 3.4 and Windows XP/WS2K3 as well, but I don't have any machines handy to test it.

As part of my patch for #23018, I'll add the manifest required so that GetVersionEx() will recognise 8.1 and 10.
History
Date User Action Args
2014-12-31 18:59:06steve.dowersetrecipients: + steve.dower, lemburg, tim.peters, loewis, pitrou, giampaolo.rodola, tim.golden, jkloth, brian.curtin, zach.ware, serhiy.storchaka
2014-12-31 18:59:06steve.dowersetmessageid: <1420052346.12.0.0144530204378.issue19143@psf.upfronthosting.co.za>
2014-12-31 18:59:06steve.dowerlinkissue19143 messages
2014-12-31 18:59:05steve.dowercreate