This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author gmt
Recipients Arfrever, cgrohmann, djc, dstufft, eric.araujo, gmt, scoder
Date 2014-12-29.11:55:02
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
Perhaps it is worth addressing, briefly, the following hypothetical question, as a litmus test against the faint dis-encapsulation code-smell some folks might be picking up from this:

In a hypothetcial world without setuptools, would these changes have merit?

I'd say, technically, yes.  In the Extension case, we are just really trying to ask, "is it a tuple", and in the Distribution case, "Can we use this thing to finalize/reinitialize Commands?", so, in theory, at least, these isinstance() checks are less pythonic than the hasattr checks in my patches.

That stated, I think isinstance was the sensible way to code this in a vacuum, and obviously, I would never have thought this was a fantastic and self-evident proposal, were it not for these setuptools problems.
Date User Action Args
2014-12-29 11:55:03gmtsetrecipients: + gmt, scoder, cgrohmann, djc, eric.araujo, Arfrever, dstufft
2014-12-29 11:55:03gmtsetmessageid: <>
2014-12-29 11:55:03gmtlinkissue23102 messages
2014-12-29 11:55:02gmtcreate