Author eric.snow
Recipients Arfrever, alex, asvetlov, benjamin.peterson, eric.araujo, eric.snow, ezio.melotti, flox, gregory.p.smith, josh.r, pitrou, refi64, rhettinger, serhiy.storchaka, tonn81, yselivanov
Date 2014-12-17.06:31:11
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1418797872.12.0.0078679086957.issue16991@psf.upfronthosting.co.za>
In-reply-to
Content
I'm open to suggestions on how to help make the patch more reviewable.  Currently at roughly +2500 lines of code it's a lot to ask someone to review.  While probably not the only way to help reviewers, I expect the best thing I could do is to split the patch up into several smaller parts.

However, I could use some insight into the best way to approach that.  I keep considering factoring out the iterator/view boilerplate into helpers (macros?) in a separate patch.  That would go a long way to making the actual cOrderedDict implementation more reasonably sized.  I'm just not convinced yet it's the *right* approach.
History
Date User Action Args
2014-12-17 06:31:12eric.snowsetrecipients: + eric.snow, rhettinger, gregory.p.smith, pitrou, benjamin.peterson, ezio.melotti, eric.araujo, Arfrever, alex, asvetlov, flox, serhiy.storchaka, yselivanov, refi64, josh.r, tonn81
2014-12-17 06:31:12eric.snowsetmessageid: <1418797872.12.0.0078679086957.issue16991@psf.upfronthosting.co.za>
2014-12-17 06:31:12eric.snowlinkissue16991 messages
2014-12-17 06:31:11eric.snowcreate