Message 232785 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	gvanrossum, martin.panter, vstinner, yselivanov
Date	2014-12-17.00:27:58
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<CAMpsgwa_KtSAVD6F1F7821NQG8V1s9EvpUKwO_QLmKrOiQg=9Q@mail.gmail.com>
In-reply-to	<CAP7+vJKuLZp2g1qB0mRcCvpKpJE+2yxpHXx1jea74fmoccN_zw@mail.gmail.com>

Content
> why was Server there at all? Tests? If you cannot answer, who can answer? :-) https://code.google.com/p/tulip/source/detail?r=f136c04d82c0 (You added Server to __all__.) I don't see any use case which needs to create explicitly a Server class. There are the create_server() method and start_server() function for that. By the way, the Server class is documented as asyncio.Server, which is the same mistake than asyncio.BaseEventLoop: https://docs.python.org/dev/library/asyncio-eventloop.html#asyncio.Server I propose to update the doc for Server, replace asyncio.Server with asyncio.base_events.Server.

> why was Server there at all? Tests?

If you cannot answer, who can answer? :-)
https://code.google.com/p/tulip/source/detail?r=f136c04d82c0 (You
added Server to __all__.)

I don't see any use case which needs to create explicitly a Server
class. There are the create_server() method and start_server()
function for that.

By the way, the Server class *is* documented as asyncio.Server, which
is the same mistake than asyncio.BaseEventLoop:
https://docs.python.org/dev/library/asyncio-eventloop.html#asyncio.Server

I propose to update the doc for Server, replace asyncio.Server with
asyncio.base_events.Server.

History
Date	User	Action	Args
2014-12-17 00:27:58	vstinner	set	recipients: + vstinner, gvanrossum, martin.panter, yselivanov
2014-12-17 00:27:58	vstinner	link	issue23046 messages
2014-12-17 00:27:58	vstinner	create