Author brett.cannon
Recipients brett.cannon, eric.snow, ncoghlan
Date 2014-12-08.16:18:58
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1418055538.78.0.471721917483.issue23014@psf.upfronthosting.co.za>
In-reply-to
Content
I continue to be bothered by how we designed importlib.abc.Loader.create_module(). I don't like that it's optional and I don't like that it can return None.

I would much rather make it so that importlib.abc.Loader.create_module() was a static method that does what importlib.util.module_from_spec() does. I would also like importlib to throw a fit if exec_module() was defined on a loader but not create_module() with a DeprecationWarning to start and then an AttributeError later (as I said, this requires exec_module() defined and does not play into the whole load_module() discussion). This should also hopefully promote people subclassing importlib.abc.Loader more as well.

What do other people think?
History
Date User Action Args
2014-12-08 16:18:58brett.cannonsetrecipients: + brett.cannon, ncoghlan, eric.snow
2014-12-08 16:18:58brett.cannonsetmessageid: <1418055538.78.0.471721917483.issue23014@psf.upfronthosting.co.za>
2014-12-08 16:18:58brett.cannonlinkissue23014 messages
2014-12-08 16:18:58brett.cannoncreate