Author hakril
Recipients hakril, mark.dickinson, r.david.murray, rhettinger, serhiy.storchaka, vstinner
Date 2014-12-07.21:26:59
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1417987619.48.0.191261477246.issue22939@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the comments.
I corrected the patch and updated the test. I also added a test that check the behavior of setstate with negative indice.

Just one question:

>  __setstate__ must implement the same check.

Why should __setstate__ check for PY_SSIZE_T_MAX (throwing OverflowError when unpickling) if the check will be done when calling next on the resulting iterator ?
History
Date User Action Args
2014-12-07 21:26:59hakrilsetrecipients: + hakril, rhettinger, mark.dickinson, vstinner, r.david.murray, serhiy.storchaka
2014-12-07 21:26:59hakrilsetmessageid: <1417987619.48.0.191261477246.issue22939@psf.upfronthosting.co.za>
2014-12-07 21:26:59hakrillinkissue22939 messages
2014-12-07 21:26:59hakrilcreate