Author zach.ware
Recipients alexandre.vassalotti, brett.cannon, georg.brandl, kbengine, pitrou, python-dev, steve.dower, vstinner, zach.ware
Date 2014-11-25.04:35:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1416890115.63.0.78553345935.issue22676@psf.upfronthosting.co.za>
In-reply-to
Content
This is still causing a somewhat serious warning on Windows, see [1] for example.  The condition warned about affects every platform.

It took me some time to make sense of that function, but I think I finally understand what's going on.  I think Steve's suggestion of initializing module to Py_None would be fine, or just pass in a known good object like global instead since the 'obj' parameter is only used for error message formatting.  Either way, I think the error check at Modules/_pickle.c:1657 [2] should either use reformat_attribute_error() or do the reformatting itself (to provide a different message) because I don't think the AttributeError message from get_dotted_path would be anywhere close to correct (especially if 'obj' is given as Py_None).

[1] http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/8969/steps/compile/logs/stdio
[2] Steve: the 'Comment:' label in the form is a handy link to the devguide section about how magic links work.  In this case, it's filepath.ext:number
History
Date User Action Args
2014-11-25 04:35:15zach.waresetrecipients: + zach.ware, brett.cannon, georg.brandl, pitrou, vstinner, alexandre.vassalotti, python-dev, steve.dower, kbengine
2014-11-25 04:35:15zach.waresetmessageid: <1416890115.63.0.78553345935.issue22676@psf.upfronthosting.co.za>
2014-11-25 04:35:15zach.warelinkissue22676 messages
2014-11-25 04:35:14zach.warecreate