Message 231572 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	JocelynJ
Recipients	Avneesh.Chadha, JocelynJ, christian.heimes, r.david.murray, serhiy.storchaka
Date	2014-11-23.17:35:31
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1416764131.8.0.78460832027.issue22915@psf.upfronthosting.co.za>
In-reply-to

Content
The only explicit documentation I found on SystemId is from the java specification (it is my understanding that python sax implementation is adapted from Java one): http://www.saxproject.org/apidoc/org/xml/sax/InputSource.html#setSystemId%28java.lang.String%29 The documentation says that "The system identifier is optional if there is a byte stream or a character stream". So, I agree that Serhiy's patch looks correct. Note that I'm not sure that my testcase with a subprocess is covered by Serhiy's tests, as these tests call parser() with a file object.

The only explicit documentation I found on SystemId is from the java specification (it is my understanding that python sax implementation is adapted from Java one):
http://www.saxproject.org/apidoc/org/xml/sax/InputSource.html#setSystemId%28java.lang.String%29

The documentation says that "The system identifier is optional if there is a byte stream or a character stream".

So, I agree that Serhiy's patch looks correct.

Note that I'm not sure that my testcase with a subprocess is covered by Serhiy's tests, as these tests call parser() with a file object.

History
Date	User	Action	Args
2014-11-23 17:35:31	JocelynJ	set	recipients: + JocelynJ, christian.heimes, r.david.murray, serhiy.storchaka, Avneesh.Chadha
2014-11-23 17:35:31	JocelynJ	set	messageid: <1416764131.8.0.78460832027.issue22915@psf.upfronthosting.co.za>
2014-11-23 17:35:31	JocelynJ	link	issue22915 messages
2014-11-23 17:35:31	JocelynJ	create