This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients Arfrever, alanmcintyre, dw, eric.araujo, kasal, loewis, mcepl, ocean-city, pitrou, r.david.murray, serhiy.storchaka
Date 2014-11-14.20:03:03
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1415995385.75.0.0181469769399.issue14099@psf.upfronthosting.co.za>
In-reply-to
Content
Thank you David for your benchmarks and patch. There are several backward compatibility issues with the reading from ZipFile opened for write and from closed ZipFile. This behavior is mostly undocumented (except the reading from closed ZipFile), but even our tests depend on it and changing it could break user code with good chance.

Here is a patch which preserves current behavior. Added new tests to check this behavior explicitly. Other advantage of the patch is that it doesn't change the signature of ZipExtFile constructor at all.

Benchmarks don't show stable significant difference between patched and unpatched versions.
History
Date User Action Args
2014-11-14 20:03:06serhiy.storchakasetrecipients: + serhiy.storchaka, loewis, alanmcintyre, pitrou, ocean-city, mcepl, eric.araujo, Arfrever, r.david.murray, kasal, dw
2014-11-14 20:03:05serhiy.storchakasetmessageid: <1415995385.75.0.0181469769399.issue14099@psf.upfronthosting.co.za>
2014-11-14 20:03:05serhiy.storchakalinkissue14099 messages
2014-11-14 20:03:05serhiy.storchakacreate